[merge] Inline _unescape_xml_cached

John Arbash Meinel john at arbash-meinel.com
Mon Dec 18 18:24:27 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

It turns out that the overhead from 350,000 calls to
_unescape_xml_cached was very measurable (about 500ms).

So this patch inlines the cache lookups to save some more time during
fileids_altered_by_revisions_ids. I'm now down to around 5.4s during
parsing of the whole inventory.

I'm going to try and not tune this function anymore, since I think I'm
about at the point of diminishing returns, versus other things which
should be much faster.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFhtzaJdeBCYSNAAMRAnYmAKCRIG0Ty3ZE/9vwJav5fASWBYaX4ACggX2d
1nsxG9UgA+JtKWmEAIvJb5Q=
=nENA
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unescape_inline.patch
Type: text/x-patch
Size: 3564 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061218/a8ca80d1/attachment.bin 


More information about the bazaar mailing list