[MERGE] Bugfix #55276: on win32 cat, bundle and diff commands provide binary output without mangling line-endings

Aaron Bentley aaron.bentley at utoronto.ca
Sat Dec 16 18:55:47 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Alexander Belchenko ?8H5B:

>>> Actually only diff command has encoding_type = 'exact',
>>> both cat and bundle commands use 'strict'.
> 
> After inspecting attributes of all built-ins non-hidden command
> I see that only 2 commands have exact encoding type: diff and version-info.

bundle and cat should both be exact.  They both emit bytes, not
characters.  So strict is wrong; output must not be treated as
characters and re-encoded.

With bundles, the metadata is utf-8 encoded, and the diffs are in
whatever encoding each file is in.

Cat's purpose is to output a file, so again, it's bytes.

> I don't think that parsing output of version-info will be difficult
> with CRLF line-endings, so I think this command don't require binary
> stdout on win32.

I'm surprised it's exact, but maybe the reason was so that when you
include its output in a file, you get the same result on every platform.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFhEEz0F+nu1YWqI0RApqyAJ93NBx1goc6ENAnrTWOULPrumZzFACdFy0v
z+pFpuQAFyn9FZZgPSEcBxk=
=d6Fs
-----END PGP SIGNATURE-----




More information about the bazaar mailing list