[PATCH] [0.13] Bug #74759

Vincent Ladeuil v.ladeuil+lp at free.fr
Wed Dec 13 13:00:44 GMT 2006


>>>>> "aaron" == Aaron Bentley <aaron.bentley at utoronto.ca> writes:

    aaron> Aaron Bentley has voted +1.
    aaron> Status is now: Approved
    aaron> Comment:

    aaron> I know I don't often approve your patches.  It's
    aaron> nothing personal, it's just that you tend to work in
    aaron> areas that I'm not comfortable with.

No problem.

    aaron> That username/password parsing looks kinda sketchy,
    aaron> though.  There's nothing built into urlparse et al?

Indeed. I just copy/pasted the code from urllib2 but I will look
into that later (I plan to add tests for http authentication
(plain and proxy) and enhance a bit the urllib implementation),
I'll take that into account then.

And yes, there is an urllib.splitpasswd function.

       Vincent




More information about the bazaar mailing list