[MERGE] Bugfix #55276: on win32 cat, bundle and diff commands provide binary output without mangling line-endings

Alexander Belchenko bialix at ukr.net
Wed Dec 13 08:37:24 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Attached patch provide blackbox tests that illustrate problem
and fix for cat, bundle and diff command.

Fix made by providing new attribute of Command object: binary_stdout.
When this attribute is True self.outf object forced to be binary
stream instead of text one (by default). Because some tests
use StringIO file-like object instead of real sys.stdout
so I need to explicitly check for presence of fileno attribute.

The bug #55276 reports only about *real* problem with cat command,
but I think bundle and diff also require binary output.
(Right now bundle provide workaround by using '--output' flag;
diff generated on win32 could be applied with 'patch --binary').

Alexander

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFf7tbzYr338mxwCURAjL5AKCSHSYAd1VhrFOvdCBsYBMT7gXlgwCdERsP
PNv5ITkgRlgnhTadvwTcmew=
=ZOrB
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: win32.binary-stdout.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20061213/4f71d312/attachment.diff 


More information about the bazaar mailing list