[PATCH] Bug 73948 test suite related fix
Aaron Bentley
aaron.bentley at utoronto.ca
Wed Dec 13 05:12:45 GMT 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Aaron Bentley wrote:
> Aaron Bentley has voted +1.
> Status is now: Approved
> Comment:
> The word "could" is ambiguous in "RFC2616 14-16 says that invalid Range headers could be ignored". Especially when referring to RFCs, MAY is clearer.
>
> But in this case, it's actually MUST, not SHOULD or MAY. Also, it should read "14.16" (I thought 14-16 was a range, at first.)
Actually, as I read it, this implementation is slightly wrong.
First of all, the correct section is 14.35 -- this is the Range header,
not Content-Range.
end values that are >= file_size do NOT make a range invalid. end
values should be truncated to file_size - 1.
start values that are >= file_size do NOT make a range invalid. But
they make it UNSATISFIABLE, and should cause a 416.
Finally, ranges whose start value is greater than its end value are
INVALID, and should typically cause a 200.
But those are errors in the original, not errors in your fixes, so I'll
leave them as is.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFf4vN0F+nu1YWqI0RAisFAJ9ilHbo/U7YCtlEYjdCJjfRNK83eACggpBS
wM+Tm6e3EwGoCueKjOodcjA=
=723q
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list