[MERGE] 'bzr selftest --clean' allows easily clean temporary tests directories

Vincent Ladeuil v.ladeuil+lp at free.fr
Tue Dec 12 14:22:53 GMT 2006

>>>>> "bialix" == Alexander Belchenko <bialix at ukr.net> writes:

    bialix> After discussion about this change I personally don't think that
    bialix> bzrtools is *right* solution for me (personally), because not all system
    bialix> has bzrtools.

    bialix> I'd like to change 'make clean' to use cross-platform solution by using
    bialix> python scripts (something similar as I did for clean-docs).

    bialix> But anyway, why for clean all (that what 'make clean' do) when I want to
    bialix> clean only temp tests directories?

The canonical way would be to define a new target clean-selftest
and have it mentioned in the dependencies of clean.

....<reading Makefile>

Hmm, clean associated action already does : 'rm -rf test????.tmp'
but do not mention clean-docs in its dependencies ?

Anyway, I, for one, would prefer the selftest --clean approach.

Otherwise the following patch illustrate my points.


=== modified file 'Makefile'
--- Makefile	2006-11-10 02:34:00 +0000
+++ Makefile	2006-12-12 14:21:08 +0000
@@ -18,9 +18,11 @@
 	# high priority to fix
 	pyflakes bzrlib | grep -v ' imported but unused'
+clean: clean-docs clean-selftest
 	./setup.py clean
 	-find . -name "*.pyc" -o -name "*.pyo" | xargs rm -f
 	rm -rf test????.tmp
 .PHONY: all

More information about the bazaar mailing list