[PATCH] [0.13] Bug #74759

[John Arbash Meinel]

Vincent Ladeuil wrote:
...

> +class TestProxyHttpServer(object):
> +    """Tests proxy server.
> +
> +    This MUST be used by daughter classes that also inherit from
> +    TestCaseWithTwoWebservers.
> +
> +    We can't inherit directly from TestCaseWithTwoWebservers or
> +    the test framework will try to create an instance which
> +    cannot run, its implementation being incomplete.
> +
> +    Be aware that we do not setup a real proxy here. Instead, we
> +    check that the *conention* goes through the proxy by serving
> +    different content (the faked proxy server append '-proxied'
> +    to the file names).


Minor typo here:
 *connection*

> +    Note that the proxy handling *may* modify the protocol used,
> +    the request may be against an https werver proxied thru an
> +    http proxy. So, https_request will be called, but later it's
> +    really http_open that will be called. This explain why we
> +    don't have to call self.parent.open as the urllib2 did.
> +    """

the request may be against an https server proxied through an http proxy....


But still +1, but it would be nice to have the typos corrected before
submission.

John
=:->