[rfc] why selftest -v don't use osutils.terminal_width() for formatting output?

Alexander Belchenko bialix at ukr.net
Mon Dec 11 16:21:52 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

In bzr 0.12 and early 'selftest -v' use osutils.terminal_width() to
format report. Now it's gone.

The line in question is:

self.stream.write(self._ellipsize_to_right(name, 60))

in method report_test_start() in class VerboseTestResult.
This change introduced by
revid:mbp at sourcefrog.net-20061029065311-c0db791096b06831.

I think using hardwired value 60 to format report is not good.
But probably Martin has some strong reasons to do this?

I'd like to switch hardwired 60 to (osutils.terminal_width()-20).

Alexander

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFfYWgzYr338mxwCURAp1sAJ9XaoJJp29JTknqRAAnBtokStNvcgCfXJqP
T2B9adVrv6vrhktHX35JElA=
=zb7h
-----END PGP SIGNATURE-----





More information about the bazaar mailing list