[MERGE] Remove unnecessary duplication of tests in blackbox/test_diff.py (was: Re: [rfc] question about tests in blackbox/test_diff.py)

[Alexander Belchenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel пишет:
> Alexander Belchenko wrote:
>> Looking at tests in blackbox/test_diff.py I see something strange.
> 
> ...
> 
>> I think we need create one base class (e.g. TestDiffBase) with helper
>> method (make_example_branch) and subclass all other classes correctly:
>>
>> class TestDiff(TestDiffBase):
>> class TestCheckoutDiff(TestDiff):
>> class TestDiffLabels(TestDiffBase):
>> class TestExternalDiff(TestDiffBase):
>>
>> What you think?
>>
>> Alexander
> 
> I agree.

Here the patch.

Alexander


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFfRFOzYr338mxwCURAuZ9AJ9ssJ1CUz/NhvoZAKreVZqKqgJCDwCfY2da
3LFYTpjdncheE0DLynfDMIg=
=rlF3
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix.blackbox.test_diff.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20061211/7d28e84b/attachment.diff