[patch] improved ignore pattern matching (#57637)

[Kent Gibson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



John Arbash Meinel wrote:
> Don't forget to "Reply to All" so that the list gets emailed as
> well.
>
I didn't forget.  I just didn't think there was anything that the list
would be interested in.

>
>>> OTOH I agree that that test case is both long and a bit
>>> convoluted. How about I refactor it based on the sub-group
>>> being tested (digit, alnum, ...)?  That would result in more
>>> bite sized tests.
>>>
>
> Probably it would be clearer as you say, broken up by test type.
>
Have done so in r2142 in my branch (along with your other review changes).

> You could also write a helper that takes a list, and runs
> assertMatches twice.
>
I like it.  Much neater.  That change is in r2143.
>
>>> And wrt flush_ignore_list_cache being private, at the time I
>>> was worried about plugins messing with the runtime ignores and
>>> needing a mechanism to flush the cache. Of course that is a bad
>>> fix anyway - the workingtree should be modified to detect if
>>> the ignores are dirty and rebuild the cache automatically.
>>>
>
>
> I see your point, but plugins generally only alter the global list
> before the tree is created. And certainly they wouldn't know what
> WorkingTrees have been created. So for now, I'm not sure it is
> something you really need to worry about. I can see what you are
> trying to do, but without the rest of the puzzle being done, it
> doesn't really work.
>
I totally agree - that was why I didn't pursue it.
It just concerned me for a while.

Anyway, the bundle with my latest changes follows.
That is up to and including r2143 from my branch.

Cheers,
Kent.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFeXglgoxTFTi1P8QRAtS/AKDqu9t7YINJM0YFTcDKQxyQbzoMAwCg+vty
YQg+kjHauRKGhq8H7EEOcJk=
=LBcD
-----END PGP SIGNATURE-----

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lp57637_3.patch
Type: text/x-patch
Size: 119002 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061208/d7de6d41/attachment.bin