[MERGE] fix execute handling by revert, fix #74697
Aaron Bentley
aaron.bentley at utoronto.ca
Thu Dec 7 13:55:05 GMT 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
John Arbash Meinel wrote:
> Basically, 'bzr revert' seems to be forgetting the executable bit.
>
> jdong came across it, because he modified an executable file, and after
> doing revert, the backup file was executable, but the reverted file was not.
>
> But since I can show that a plain 'revert' is failing to detect the
> executable bit change, I think our 'revert' code is just failing to
> chmod the output file.
Well, things get altogether too fancy, because of the Windows execute
bit handling.
1. we have to preserve all unix permissions on *nix platforms [1]
2. we have to preserve the execute bit on all platforms
3. if just the execute bit is changed, we should still revert it.
Anyhow, the attached bundle should fix all these problems. Sorry for
the inconvenience.
Aaron
[1] That is, when changing just the contents of a 0754 file, the output
file should also be 0754. Even though bzr doesn't version the other
bits, it should still preserve them in working trees.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFFeB050F+nu1YWqI0RAgLYAJ48/h8KQjLXGM9JQNmmI9Tcaa9xQgCfaZ4b
GoGACiav1Tc9bzoREo4RrLw=
=IxPs
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: revert-execute.patch
Type: text/x-patch
Size: 4609 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061207/83986454/attachment.bin
More information about the bazaar
mailing list