[PATCH] KnitIndex tests/fixes/optimizations (was: KnitIndex optimizations)

[Marius Kruger]

On 11/28/06, John Arbash Meinel <john at arbash-meinel.com> wrote:
>
> Dmitry Vasiliev wrote:
> >
>
> v- We actually have gotten away from adding "Modified by" lines at the
> top. Part of the point of having a VCS with annotation support is that
> these sorts of things are automatically tracked. And if all of the lines
> introduced by someone are removed, that can be shown as well.
>
> So we should probably go through the code and remove all of them. But it
> doesn't really matter right now.
>
> >  # Modified by Johan Rydberg <jrydberg at gnu.org>
> >  # Modified by Robert Collins <robert.collins at canonical.com>
> >  # Modified by Aaron Bentley <aaron.bentley at utoronto.ca>
> > +# Modified by Dmitry Vasiliev <dima at hlabs.spb.ru>
> >  #
> >  # This program is free software; you can redistribute it and/or modify
> >  # it under the terms of the GNU General Public License as published by
> > @@ -74,6 +75,7 @@
> >  import warnings
> >
>
>
I wanted to offer my services to remove all of them from all the files for
you,
but I grepped a bit and figured out that its not something which is
occurring a lot:

$ grep -ir "# Modified" *
bzrlib/knit.py:# Modified by Johan Rydberg <jrydberg at gnu.org>
bzrlib/knit.py:# Modified by Robert Collins <robert.collins at canonical.com>
bzrlib/knit.py:# Modified by Aaron Bentley <aaron.bentley at utoronto.ca>
bzrlib/tests/test_bundle.py:        # Modified files
bzrlib/tests/test_bundle.py:        # Modified
bzrlib/tests/test_bundle.py:        # Modified


$ grep -ir -E "Modified +by" *
bzrlib/builtins.py:    modified by plugins will not be tested, and tests
provided by plugins will
bzrlib/delta.py:        """Return True if file_id is modified by this
delta."""
bzrlib/knit.py:# Modified by Johan Rydberg <jrydberg at gnu.org>
bzrlib/knit.py:# Modified by Robert Collins <robert.collins at canonical.com>
bzrlib/knit.py:# Modified by Aaron Bentley <aaron.bentley at utoronto.ca>
bzrlib/msgeditor.py:    # TODO: make provision for this to be overridden or
modified by a hook
COPYING.txt:software.  If the software is modified by someone else and
passed on, we

But try the following:
$ grep -ir "Aaron Bentley" * |less
and see that a lot of the files are still Copyright to mister Bentley:)


Then I saw that there is actually a problem:
grep -ir -E "# +Author" * |less
This Author tags are everywhere, although most files is probably edited by
quite a number of people.

So if you want them gone, let me know,
as I don't have a problem removing them for you...

regards
marius


-- 



I code therefore I am.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20061130/7e1472ea/attachment.htm