[MERGE] Defer prompting for commit message until commit is mostly done [was: Fix commit --strict regression]

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:

> v- Earlier you said you were passing the CommitBuilder as the parameter,
> but here you are passing the Commit() object.
> 
> I don't really know which is best, but if you want to pass CommitBuilder
> this needs to be:
> 
>   message = message_callback(self.builder)

You're right.  I was hazy about that, but I think the right approach is
to provide the Commit object.  The comparison is done by Commit, and
there may be multiple implementations of CommitBuilder, so it doesn't
make sense to require them all to implement an API for the callback.

> And we should probably have a test either way, to make sure we don't
> accidentally change the api in the future.

Okay.  Submitting to PQM with a new test.  If my tree-compare patch is
accepted, I'll optimize the commit template generation as part of phase 2.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFFbI3z0F+nu1YWqI0RApQxAJ9zRzzoJjLYs9LtqPfiDdQZXWwrVACeP1ud
RiVv9hZjMUw4N1IJg7ijzsc=
=BCkp
-----END PGP SIGNATURE-----