[PATCH] Additional benchmarks for cache_utf8

[John Arbash Meinel]

Dmitry Vasiliev wrote:
> 
> The attached patch adds benchmarks for the case when items are missed
> from the cache as proposed by John.
> 


v- Weird. I don't know why it was working without the u''.
>      def test_encode_1k_by_1k_unicode(self):
>          """Test encoding 5 revisions 100k times"""
> -        revisions = ['\u062c\u0648\u062c\u0648' +
> +        revisions = [u'\u062c\u0648\u062c\u0648' +
>                       unicode(osutils.rand_chars(60)) for x in xrange(1000)]
>          self.time(self.encode_multi, revisions, 1000)
>  

v- Can you tell me the approximate time it takes to run these tests, and
how it changes with your new patches?

> +    def test_encode_500K_by_1_ascii(self):
> +        revisions = [unicode("test%07d" % x) for x in xrange(500000)]
> +        self.time(self.encode_multi, revisions, 1)
> +


The changes themselves all look good (+1), and I'd like to merge it
before your other patch if possible. That way we have 1 revision of
bzr.dev with the new benchmarks. And then another revision with the
actual performance improvements.

Any other +1's?

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061128/92d92175/attachment.pgp