[patch] improved ignore pattern matching (#57637)

Wouter van Heyst larstiq at larstiq.dyndns.org
Sat Nov 25 17:21:45 GMT 2006

On Mon, Nov 13, 2006 at 10:38:33PM +0800, Kent Gibson wrote:
> Attached is a patch which replaces the old fnmatch based ignore pattern
> matching with a faster and more accurate globbing engine originally
> written by Jan Hudec, and massaged a bit by me.
> Bug 57637 describes just one or two of the problems with the old fnmatch
> approach.
> The goal of this patch is to squash those and any related bugs in one hit.
> Unlike the fnmatch version, this version is fully compliant with shell
> globbing.
> It also supports a 'RE:<regex>' extension pattern for those seriously
> hard to reach places.
> Unlike Jan's original patch it does not support '**' or '***' extensions
> because I'm not satisfied that there is a consensus as to which form of
> globbing extensions we should support, and I don't want to go
> introducing a future backwards compatibility problem.
> Speaking of backwards compatibility, this patch is not.  Any ignore
> patterns making use of broken fnmatch behaviour (e.g. in fnmatch '*foo'
> will match '.foo') will no longer match.

I do appreciate fixing bug 57637, but since this isn't backwards
compatible, I'd prefer if we only broke it _once_ if we really have to.
That means deciding wether we want zsh/rsync style extensions.

has some thoughts that may be relevant.

-0 for now.

Wouter van Heyst
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061125/a852c608/attachment.pgp 

More information about the bazaar mailing list