[MERGE][0.13] Dynamic fulltext

Wouter van Heyst larstiq at larstiq.dyndns.org
Sat Nov 25 16:44:26 GMT 2006


On Fri, Nov 24, 2006 at 12:56:02PM -0600, John Arbash Meinel wrote:
> I updated my patch according to the recent feedback. Basically, it just
> simplifies the while loop, making it a for loop, and being a little bit
> clearer on the return values.
> 
> Right now, I'm in discussion with some large projects that are
> considering using bzr for there source control. So I would really like
> to get this merged for bzr 0.13.
> 
> For a project with 7500 revisions and 2500 source files, the CVS source
> is 49MB. Without the patch the converted repository is 64MB, with the
> patch, it is 58MB. (With 2500 files, it creates a full text
> approximately every 65th revision). The inventory knit itself is 11MB
> versus 5.4MB.
> 
> As the project size gets larger, this will become more and more
> important. And I'm trying to convert a project with something like
> 100,000 files and revesions, so it becomes more important for something
> like this to be done.
> 
> So I'd like to ask Wouter for a specific acceptance of this patch for
> bzr 0.13.
> 
> Also, it seems like something in my change triggers a bug in the
> iteration counter for iter_lines_added_or_present_in_versions. I already
> fixed that in a different patch (the one to fix the progress bars). But
> since it gets triggered here, I'm just fixing that little bit. (As a
> bonus, this will also fix the bug of progress bars jumping around,
> rather than monotonically increasing).
> 
> So, Wouter, can this patch be merged for 0.13? Also, are you interested
> in my progress bar fixes, or should that wait for 0.14? (I can
> understand that it is a more invasive change)

+1 to merging for 0.13. How hard would it be to check against the
current fulltext instead of the original one?

going to look up the progress bar changes again,
Wouter van Heyst
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061125/b8792a9d/attachment.pgp 


More information about the bazaar mailing list