[RFC] allow fulltext to be more dynamic

Martin Pool mbp at canonical.com
Fri Nov 24 22:17:20 GMT 2006


On 25/11/2006, at 3:53am, John Arbash Meinel wrote:

> Well, at this point I'm not sure if it should be a constant. I could
> define it at the class level, but then you are supposed to access them
> as class-level members. So do something like:
>
> class KnitVersionedFile(...
>
>   _max_delta_chain = 200
>
> ...
>
>
>   while count < KnitVersionedFile._max_delta_chain:
>     ...
>
> At least that is what I've understood from Martin and Robert. They  
> don't
> really like having class level definitions which can be overridden per
> object and accessed as 'self._max_delta_chain'.

I don't have a problem with it; in fact it seems like a decent way to  
provide a class-wide default.  It can be dangerous if it's a mutable  
object, as people can accidentally change the wrong one.


-- 
Martin







More information about the bazaar mailing list