[RFC] allow fulltext to be more dynamic
John Arbash Meinel
john at arbash-meinel.com
Fri Nov 24 16:44:59 GMT 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Henri Wiechers wrote:
> Looks good.
>
> One thing though, it assumes that the only two methods are 'fulltext'
> and 'line-delta'. It may not work if new methods are introduced. Maybe
> it would be better to do something like:
>
> while count < self._max_delta_chain:
> ...
> else:
> return False
>
> return fulltext_size >= delta_size
>
> Henri
>
I'm actually just copying the old code, but I could see changing it to:
if method != 'fulltext' or ...
But using else to fall off the end of the loop would also work.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFZyGLJdeBCYSNAAMRAkbmAJ4pgv0juCLcEPvLl8fTmi9DxLyUugCfSyDD
8nPZHfw4pD4VgtPkVlkyMg4=
=Bk06
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list