Patch: Better connection sharing for pycurl: has +2
Vincent Ladeuil
v.ladeuil+lp at free.fr
Fri Nov 24 08:52:16 GMT 2006
>>>>> "larstiq" == Wouter van Heyst <larstiq at larstiq.dyndns.org> writes:
larstiq> On Thu, Nov 23, 2006 at 12:44:32PM -0500, Aaron Bentley wrote:
>> Alexander Belchenko wrote:
>> > http://bundlebuggy.aaronbentley.com/request/%3C87slho45k2.fsf@alplog.fr%3E
>> >
>> > This patch has +2 but not merged into bzr.dev. Does it
>> > delayed for 0.14?
>> >
>> > I think BB needs one feature: date of voting. Looking
>> > at day of voting one can determine is patch forgotten or
>> > delayed, IMO.
>>
>> That might help. Unfortunately, BB doesn't retain that
>> info at the moment.
But it displays who voted and their comment, that's already
really nice !
>>
>>
>> In this case, Wouter voted for it two days ago, so I
>> assume he doesn't feel it can be merged this week.
larstiq> I'd prefer for it to go in next week, but if anyone
larstiq> feels strongly enough to convince me otherwise, go
larstiq> ahead.
+1 for next week
On a practical POV, leaving that patch un-merged can only make
the delayed merge harder, but AFAIK there is no plans to modify
_pycurl.py, so it can wait a week or two.
<related but lightly off-topic>
Otherwise, this an improvment for pycurl but I'd prefer that
people (at least devs) switch to the new urllib implementation to
give it a good real-life shaking (checking ? :-)
And I will also be interested about people feelings about making
urllib the default implementation, and if yes when. IMHO that
should not occur before 0.14 though.
I know that the urllib implementation pass the selftest suite and
also pass my daily use for weeks, but there may be corner cases
not covered by the test suite.
</related but lightly off-topic>
Vincent
More information about the bazaar
mailing list