[MERGE] Defer prompting for commit message until commit is mostly done [was: Fix commit --strict regression]

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> On 23/11/2006, at 3:12 PM, Robert Collins wrote:
> 
>> On Wed, 2006-11-22 at 11:35 -0500, Aaron Bentley wrote:
>>> I prefer the callback approach, because it doesn't require many  changes
>>> to existing code, like returning a state object.  But with either
>>> approach, we can delay prompting for the message until we're actually
>>> ready to write the revision into the knit, so even network failures
>>> would prevent us from prompting for commit messages that we can't  use.
>>
>>
>> +1 to the merge and the described better approach.
> 
> 
> +1 too

Okay, here's an implementation of the "message_callback" approach.  It
defers all message processing until after the inventories have already
been written, so if we prompt for a commit message, it's highly unlikely
that the commit will fail.

I'm proposing it for 0.14, not 0.13.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFFZhi40F+nu1YWqI0RAnzyAJ0ZiUXhjgzYWWVQQdjQZW48cq17BACfSEXN
RtzH/qmfJRguJBhEY5j44l0=
=zgII
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: commit_message_callback.patch
Type: text/x-patch
Size: 24456 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061123/77535dd3/attachment.bin