[merge] Fix commit --strict regression

Aaron Bentley aaron.bentley at utoronto.ca
Wed Nov 22 16:35:18 GMT 2006

Hash: SHA1

Commit --strict is still broken.  John's fix of changing the default
ignores isn't good enough because it doesn't fix all the bzr installs
that already have user ignores.

Since this is a regression, and we're halfway to a release candidate,
I'm submitting a patch to revert the changes.

I don't think it's the right approach anyway.  A better approach is not
to prompt the user until all checks are complete.  One way is to supply
a callback to commit.  Another approach would be to split commit into
"prepare" and "finalize" steps.

I prefer the callback approach, because it doesn't require many changes
to existing code, like returning a state object.  But with either
approach, we can delay prompting for the message until we're actually
ready to write the revision into the knit, so even network failures
would prevent us from prompting for commit messages that we can't use.

Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: revert-strict-regression.patch
Type: text/x-patch
Size: 7859 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061122/20af0555/attachment.bin 

More information about the bazaar mailing list