[PATCH] Tests for KnitContent class
Dmitry Vasiliev
lists at hlabs.spb.ru
Wed Nov 15 08:43:41 GMT 2006
Johan Rydberg wrote:
> Dmitry Vasiliev <lists at hlabs.spb.ru> writes:
>
>> While learning Bazaar codebase I've wrote tests for KnitContent
>> class. BTW it seems methods KnitContent.line_delta(_iter) don't used
>> anywhere?
>
> The patch seems kinda straight forward, at least the changes to
> knit.py. Didn't really look at the tests though :)
The tests is also straight forward. :-)
> +1 from me for the knit changes.
Actually the KnitContent's interface looks incomplete for me because of so many
places where KnitContent._lines is directly accessed.
--
Dmitry Vasiliev (dima at hlabs.spb.ru)
http://hlabs.spb.ru
More information about the bazaar
mailing list