[RFC] gzip bundle data

[Goffredo Baroncelli]

On Tuesday 14 November 2006 11:21, Alexander Belchenko wrote:
> Goffredo Baroncelli пишет:
> ...
> >
> > The table abowe, shows that is better to gzip all bundle.
> 
> Do you see my plugin 'gzipped_bundle'?

After your email, I saw your plugin ( 
http://bzr.onembedding.com/bzr.win/plugins/gzipped_bundle/ )

Your plugin compress the bundle after the bundle creation; so you 

1) create the diffs            \
2) uuencode base64 the diffs   |--> Current bundle code
3) glue all togheter           /
4) gzip the bundle             >--> Your plugin
5) send the email

My patch 
1) create the diffs                          \
2) gzip the diffs             -> my patch    |_____> Bundle code
3) uuencode base64 the diffs-gzipped         |
4) glue all togheter                         /
5) send the email

The difference is that if you send the bundle via email, the file, if binary, 
will be uuencoded a 2nd time.
With yuor approach the data are uuencoded 2 times ( at the point 2 and at the 
point 5, because after the #4 you have a binary file ).
Instead "my" bundle can be sent via email without uuencoding because it should 
be "7bit clean".

Goffredo

-- 
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) 
<kreijack_AT_inwind.it>
Key fingerprint = CE3C 7E01 6782 30A3 5B87  87C0 BB86 505C 6B2A CFF9