[RFC] Clean up progress bars during fetch
John Arbash Meinel
john at arbash-meinel.com
Thu Nov 9 18:11:32 GMT 2006
John Arbash Meinel wrote:
...
>
> \ [================ ] Phase 6/6 Copying frizbans ( 10/100)
>
> I kind of like adding 'Phase'. Maybe I should change it so the child
> update message shows up along with its xx/yyy progress.
>
> I'll play around with that.
>
> John
> =:->
I looked into including the child message in the parent progress, and I
found out why I don't want to do it. Basically, the child doesn't know
what it is really doing, it has too narrow a world view. For example,
while we are looking for what file ids have been modified across
revisions, the child only knows "Walking Content". Which it does for all
knits. It doesn't know *why* it is "walking content".
So we still need the meta information to be given from the parent.
So I did an update which does this:
- [==== ] Fetching 1/6 Finding involved files ( 905/8236)
Basically, when a ProgressPhase is created, it sets the overall progress
indicator, and then as next_phase() is called it updates the second message.
However, I'm tempted to just always force it to 'Phase 1/6'. I think
'Fetching' is actually less helpful than just 'Phase'.
Thoughts?
- [==== ] Phase 1/6 Finding involved files ( 905/8236)
Maybe even lower case:
- [==== ] phase 1/6 Finding involved files ( 905/8236)
John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061109/0582c52c/attachment.pgp
More information about the bazaar
mailing list