[RFC] Clean up progress bars during fetch
John Arbash Meinel
john at arbash-meinel.com
Wed Nov 8 23:57:27 GMT 2006
...
>
> What would you like to see? I've thought about adding a XX/XXXX entry,
> to include the fraction that the child claims it has finished. That
> would also help feel like something is actually getting done.
I looked into adding it, and I tried adding it in a few places. My
favorite is this one:
| [===== ] 1/6 Finding involved files ( 173/8236)
It moves the overall progress to before 'Finding involved files', and
uses () to make it clear that this is the smaller portion of the action.
Since we are switching to "Phase" based progresses, I think this is the
nicest overall look.
There are lots of alternatives, though:
No parenthesis
/ [===== ] 1/6 Finding involved files 578/8236
Overall progress next to sub progress
/ [===== ] Finding involved files 1/6 547/8236
Bar inbetween:
\ 1/6 Finding involved files [====== ] 1151/8236
Bar at end:
| 1/6 Finding involved files 2412/8236 [====== ]
Bar at end with brackets:
/ [1/6] Finding involved files 1789/8236 [====== ]
Having played with them, I still prefer the first one. Also, this may
make it more apparent why we need to fix http readv.
On the local network, the download happens fast enough, that the bulk of
the time is spent Analyzing the returned data, so the progress looks
good. Over a slower connection, it stays at 0/8236 for much longer than
it should. (Not to mention the total download time should be improved
because we are mixing download time with analyzing time, rather than
purely serializing them).
Anyway, attached is a diff just against the previous version, which lets
you see the new progress bars with child progress indicators.
I almost would avoid adding the child progress until we get http fixed.
Because it really does look like we are hung. Having the number there
makes it worse.
John
=:->
PS> You can grab the branch from:
http://bzr.arbash-meinel.com/branches/bzr/0.13-working/fix_fetch_progress/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: progress_with_child.diff
Type: text/x-patch
Size: 3688 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061108/03d99c79/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061108/03d99c79/attachment.pgp
More information about the bazaar
mailing list