[MERGE] Better connection sharing for pycurl
John Arbash Meinel
john at arbash-meinel.com
Wed Nov 8 17:02:34 GMT 2006
Vincent Ladeuil wrote:
>>>>>> "jam" == John Arbash Meinel <john at arbash-meinel.com> writes:
> >> - curl.setopt(pycurl.RANGE, self.range_header(ranges, tail_amount))
> >> - self._curl_perform(curl)
> >> + self._curl_perform(curl, ['Range: bytes=%s'
> >> + % self.range_header(ranges, tail_amount) ])
> jam> ^- In looking it over again, I did see this, which seems
> jam> to be >79 chars, and has an extra space that doesn't
> jam> need to be there.
> Fixed sir. The line is now 76 long, sir.
> jam> But you still have a +1 from me.
> Thank you sir, I'll ping again next week :)
Just to re-ping this. It updates pycurl support so we have fewer total
connections to the remote host, and allows plain 'get()' requests (like
for .kndx files) to use the same connection as readv() requests (for .knit).
And it sounds like you've also tested that it works with Andrew's POST
changes, so it still has a +1 from me.
Can someone else look this over?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061108/3997d925/attachment.pgp
More information about the bazaar