[MERGE] Mystery of progress is solved

John Arbash Meinel john at arbash-meinel.com
Fri Nov 3 23:34:01 GMT 2006


I'm not sure how to test this, so for now, I'm just going to ask that we
merge this patch.

Basically, I was investigating why progress bars take so long to start
up, because I can see that the updates are happening. It took me a while
to remember, but then I remembered... 'time.clock()' measures CPU time
on Linux platforms (on Win32 it measures high-resolution wall-clock time).

So what is happening is that we are spending all of our time in Suspend
mode because of latency, and time.clock() isn't incrementing at all. So
when the progress bar shows up, we have spent 1 second of *processor*
time, and likely much much more than that in wall time.

The attached patch reverts the code back to the old 'time.time()'
values. Now, I know one of the reasons we switched to time.clock() was
because we were trying to decrease the overhead of calling time.time().
But I think we just need to live with it. Because this was just broken.

This makes a *lot* of remote operations feel snappier. Because it
doesn't just sit there with no information.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: use_time_not_clock.patch
Type: text/x-patch
Size: 2018 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061103/ba3e9c4b/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061103/ba3e9c4b/attachment.pgp 


More information about the bazaar mailing list