Commit does not allow missing email address but whoami says this is allowed

[John Arbash Meinel]

Martin Pool wrote:
> On  1 Nov 2006, John Arbash Meinel <john at arbash-meinel.com> wrote:
>> I think the whole thing should be updated to something more like:
>>
>> unique_chunk = osutils.rand_chars(16)
>> try:
>>   user = self._config.user_email()
>> except errors.NoEmailInUsername:
>>   user = sanitize(self._config.username())
>> s = '-'.join(unique_chunk, compact_date(self._timestamp), user)
> 
> +1
> 
> We could even save some space by just using the username part of the
> address in this context; that's probably generally enough to give some
> clue to what's in it.
> 

So are you happy with the other changes? Putting the unique chunk at the
beginning. Using rand_chars instead of rand_bytes?

Also, I actually agree with someone else's suggestion to use 'r' as the
first character. To help avoid collisions with other namespaces. I might
even consider using 'bzr:' to be similar to other namespaces that we are
using "Arch-1:" "svn:", etc.

Anyway, it is arbitrary, I'll go ahead and write up the changes, but I
want to get a small clarification about what you like.

Also, we had discussed using trie compression for revision ids, and
putting the random stuff at the beginning would decrease its
effectiveness. Is that something we want to keep?

I'll merge the small fix first (switching to not requiring the email)
and then we can discuss the rest.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061102/33b25001/attachment.pgp