[patch] fix bug 65714 bzr 0.11 takes an inordinate amount of time to process a commit

[Cheuksan Edward Wang]

On 10/30/06, Martin Pool <mbp at canonical.com> wrote:
>
> On 29 Oct 2006, Cheuksan Edward Wang <wang02139 at gmail.com> wrote:
> >
> > Replace python's difflib by patiencediff because the worst case
> > performance is cubic for difflib (get_matching_blocks) and people
> committing
> > large data
> > files are often hurt by this. The worst case performance of patience is
> > quadratic. Fix bug 65714.
> >
> > If there is an easy way to run benchmarks, can someone tell me how to
> run them?
> > I want to see the change in commit time and size of the knits.
>
> As Aaron said, you can do 'bzr selftest --benchmark'.  This doesn't
> report on the *size* of the knits at the moment (perhaps it should),
> but only on the runtime.  If you could please run that with and without
> then we can merge this.


Sure. I'll do that tonight since it takes a long time to run the benchmarks.


> -                delta_seq = KnitSequenceMatcher(None, old_texts,
> new_texts)
> > +                delta_seq = bzrlib.patiencediff.PatienceSequenceMatcher
> (
> > +                                                 None, old_texts,
> new_texts)
> >              return self._make_line_delta(delta_seq, content)
>
> This constructor passes an is_junk function parameter, which (I think)
> we never use, and which is rather less useful for patiencediff.  It may
> (or may not) give a small improvement to remove support for that.


Patience doesn't support is_junk. It's just a dummy parameter.


--
> Martin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20061030/0d758f39/attachment.htm