[BUG][0.12] bench_bundle imports the wrong 'read_bundle'

John Arbash Meinel john at arbash-meinel.com
Tue Oct 24 16:39:13 BST 2006


The bench_bundle tests that were recently added are importing the wrong
'read_bundle' function. So when I updated bzr to lazily import the
function, it now is grabbing the lazy object.

The attached patch gets the benchmark tests running again. And changes
the imports to import as private functions to help avoid this problem in
the future.

Some of them are slow enough we should probably be skipping them. I
thought we weren't running the 1000 revision tests, but it seems those
did get merged. Martin was just running the tests, and 1 of them was
taking 149653319ms or ~41 hours to complete a single test on our
benchmark machine. Which is not really what we want to be testing. A
couple minutes is a good time, an hour is reasonable, but beyond that
isn't a very usable test. Maybe it allows us to show just how much
faster we can become, but it isn't something we want to run often.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: use_the_right_read_bundle.diff
Type: text/x-patch
Size: 1536 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061024/68829ff2/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061024/68829ff2/attachment.pgp 


More information about the bazaar mailing list