[PING][MERGE][0.13] Cleanup the ConnectionError for ssh failures

Vincent Ladeuil v.ladeuil at alplog.fr
Tue Oct 24 14:33:26 BST 2006


>>>>> "jam" == John Arbash Meinel <john at arbash-meinel.com> writes:

    jam> I decided not to merge this into 0.12 without another review. So I'm
    jam> pinging to try and get it reviewed.

    jam> John

<snip/>

    >> 1) SocketConnectionError

I like the fact that we will differentiate between various
connection related errors. But I think in that case
OpenConnectionError may be more appropriate (port is always
related to socket no ?).

There are some other places that will need fixing in other
transports. It seems to be mostly hhtp ones so I can handle that
once your patch is merged (and mines too :).

+1 (if renamed OpenConnectionError or something else related to
    initial use of the socket)

        Vincent




More information about the bazaar mailing list