[patch]bug 32054 if commit fails commit message draft is lost
John Arbash Meinel
john at arbash-meinel.com
Mon Oct 23 17:38:52 BST 2006
Martin Pool wrote:
> On 19 Oct 2006, Cheuksan Edward Wang <wang02139 at gmail.com> wrote:
>> I have modified the code and tests according to your comments except the
>> 'replace' part. The changeset is attached. I'll see what I can do with 5798.
>
> Thankyou.
>
> +1 with comments, taking
>
...
>
> This is large enough and self-contained enough that it should be in a
> separate method. If someone else approves it I'll fix that and merge.
>
>
+1 for 0.13 after factoring that out into a separate function. I'd go
for 0.12, but I want to get a easy rc1 out today rather than waiting for
everything to come in.
Don't forget Cheuksan's follow up patch.
John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061023/4036ca57/attachment.pgp
More information about the bazaar
mailing list