[0.12] avoid MSG_WAITALL in tests

John Arbash Meinel john at arbash-meinel.com
Mon Oct 23 14:13:20 BST 2006


Alexander Belchenko wrote:
> Martin Pool пишет:
>> This removes use of the MSG_WAITALL flag to recv, which is not portable.
>> The problem was previously reported by Alexander (iirc) but I don't
>> think it has a bug number.   John, would you please merge this for 0.12?
>>
>>  http://sourcefrog.net/bzr/win32
> 
> With this test there is no more tracebacks during selftest but at the
> end of selftest anyway error:
> 
> bzr: ERROR: [Errno 13] Permission denied:
> u'D:/Bazaar/sandbox/win32.mbp/test0000.tmp\\blackbox.test_serve.TestBzrServe.test_bzr_serve_inet_readonly\\home\\.bzr.log'
> 
> 
> I think it's unrelated to your patch. Only just for information.
> 
> +1 on your patch.
> 
> -- 
> Alexander
> 

Thanks for testing it. I merged and have submitted it to the PQM, it
should be in 0.12.

By the way, this was bug 66356:
https://launchpad.net/products/bzr/+bug/66356

It probably shouldn't be marked as critical, but it was something that I
wouldn't have been happy releasing 0.12rc1 without fixing.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061023/e2e61507/attachment.pgp 


More information about the bazaar mailing list