[PING] [PATCH] show full name of plugin in help

[Alexander Belchenko]

Aaron Bentley пишет:
> Alexander Belchenko wrote:
>> Anyone can simply download tarball with plugin release, unpack it and
>> simply place it to ~/.bazaar/plugins. And it's *just* *works*.You don't
>> need to care about period, comma and all that jazz. And IMO it's *right*
>> *thing*.
> 
> I would prefer for the tarball to be extracted without renaming the
> directory, but I think it's more important to adhere to Python package
> naming conventions.  I'll see if I can improve the bzrtools installation
> instructions, though.
> 
>> All commands that I use from bzrtools works well either bzrtools in
>> bzrtools-0.11 (0.12) directory or simply bzrtools, or even
>> bzrtools.bialix (when I want to hacking it a bit). If bzrtools have
>> hardwired assumptions about their location in bzrlib.plugins.bzrtools --
>> then it stupid for me.
> 
> The hardwired assumptions are in the test suite.

It's invisible for most users.

>> Because bzr-gtk is such stupid thing. It *require* to be installed to
>> bzrlib.plugins.gtk. That's in turn require to have bzr itself to be
>> installed
> 
> No, it doesn't.  Anything in ~/.bazaar/plugins or the Windows equivalent
> will be named as bzrlib.plugins.foo
> 
> But also, if you want to put the plugin in bzrlib/plugins instead,
> that's fine.  And it still doesn't require to you install bzr.
> 
>> I think that installing plugins it's *bad* idea and break main plugins
>> idea. And require to plugin have canonical python name is also bad idea
>> because now it works in any case.
> 
> Having non-canonical names doesn't give you much, because you can only
> have one copy of a plugin at a time.  It makes it hard for bzr to detect
> particular plugins, and for plugins to detect and use each other.

If some plugins want to be registered in bzr with some "canonical" name
then IMO there is should be the way to do this explicitly (like a
register_command) and not rely on name of directory where plugin
resides. In this case anyone can say about: "one plugin can find other
by registered/canonical name".

But I think it's a hole in plugin design if one plugin want to search
another. Plugins in bzr add some functionality to bzr itself. And this
functionality should be visible for all clients, not separating between
bzr core and plugins. bzrlib don't search plugin by exact names, is not?

--
Alexander