[MERGE] Better connection sharing for pycurl

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
>>>>>> "jam" == John Arbash Meinel <john at arbash-meinel.com> writes:
> 
> 
>     jam> It has my approval (+1) once I sorted through it.
> 
>>>>>> "Robert" == Robert Collins <robertc at robertcollins.net> writes:
> 
>     Robert> On Tue, 2006-09-12 at 11:48 +0200, Vincent Ladeuil wrote:
>     >> Hi,
>     >> 
>     >> By specifying explicitly the 'Range' header, we avoid the need to
>     >> use two different curl objects (and two connections to the same
>     >> server).
> 
>     Robert> This needs a NEWS section to be merged I think. +1 for 0.12.
> 
> Looks like I forget to follow up this one. So here is a new
> attempt with a NEWS entry and after a merge from a fresh bzr.dev.
> 
> Or did I already miss the train for 0.12 ? :-)
> 
>         Vincent

I think we did miss 0.12 for this one. It is just a little bit larger of
a change than I am comfortable bringing in after a freeze.  However, I
would really like to see it get a second +1 (I've already given it 1),
so that we can bring it in early next week as soon as bzr.dev thaws again.

...

> -        curl.setopt(pycurl.RANGE, self.range_header(ranges, tail_amount))
> -        self._curl_perform(curl)
> +        self._curl_perform(curl, ['Range: bytes=%s'
> +                                  % self.range_header(ranges, tail_amount) ])

^- In looking it over again, I did see this, which seems to be >79
chars, and has an extra space that doesn't need to be there.

But you still have a +1 from me.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFNCn/JdeBCYSNAAMRAnaDAKDHOXYTSKprHpTaYLH435KqgV0XtgCfdBbe
yYNXzp8nh3wxbLrBHBI2cd0=
=lvlZ
-----END PGP SIGNATURE-----