[MERGE] Fix MemoryTransport().abspath('/foo')

John Arbash Meinel john at arbash-meinel.com
Mon Oct 16 08:18:47 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> John Arbash Meinel wrote:
> [...]
>> v- Make sure you update to the latest bzr.dev. I got rid of these doc
>> string tests, in favor of real tests in the test suite. (I left them as
>> as examples, but not as doc tests).
>>
>> It turns out DocTest doesn't play nice with lazy_import. So where they
>> conflict, I made lazy_import win.
> 
> Makes sense.  I've moved the tests to test__combine_paths.
> 
> I've left one of the new cases in the docstring, because I think it's worth
> giving an example of what _combine_paths does with absolute paths:
> 
> +            >>> t._combine_paths('/home/sarah', '/etc')
> +            '/etc'
> 
>> Other than the one test, it looks good to me.
> 
> Thanks!
> 
> I've attached a current diff of what's at
> http://people.ubuntu.com/~andrew/bzr/memory-transport-abspath/, for the curious.
> 
> -Andrew.

This looks good, I'll get it submitted.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFMzJXJdeBCYSNAAMRAuv8AKCEygrxzcDTb3m3uK9tC2f6DTzMqwCeLCxP
GEova7i5ytTAo8y6RHQvg+U=
=9vop
-----END PGP SIGNATURE-----




More information about the bazaar mailing list