[patch] fix bug 30190 "'bzr cat' requires full path in old revision"

[Cheuksan Edward Wang]

Thanks. I have modified the code according to your suggestions and added
more tests for the exceptions. The new changeset is attached.



> Perhaps it's better to have
>
>   if new
>   elif old
>   elif ...
>
> than returning from multiple points - I think it makes the
> alternatives a little more clear, but it's not a big deal.
>
> So, to be strictly TDD, if it's worth raising exceptions in the other
> cases then you should add tests for them too.  Possibly these are so
> obvious it's not worth testing but on the other hand they're easy to
> test.
>
> So +0.8 from me, pending more tests -- anyone else?
>
> --
> Martin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20061016/c39d0f76/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_30190_2.patch
Type: text/x-patch
Size: 12310 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061016/c39d0f76/attachment.bin