[merge] Registry

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> On 12/10/2006, at 23:41 , Aaron Bentley wrote:
> 
>> Martin Pool wrote:
>>
>> "dont" and "cant" are
>> acceptable in symbol names, but I don't think they belong in doctexts or
>> comments.  (Though "cant" is a real word that means something else.)
> 
> Actually I find them a little distasteful in identifiers, and would
> either remove the negative (thing.can_eat_peanuts), or expand it
> (CannotDance).  The second is a bit harder to justify though.

I don't think they're especially good in identifiers, just "acceptable".
 I've been inclined to use them occasionally in exception class names.
But I will prefer Cannot to Cant in the future.

> Well, one thing we can do is to give review comments but say "but I'll
> fix all of these when I merge them" -- this can apply to either code or
> doc changes.  Then other people know what was done and the original
> author gets the feedback, but we don't need to block.
> 
> If I'm reviewing English style or spelling I do try to give an
> alternative text.  Sometimes this just shows that I misunderstood the
> original and it can be more clear.

This is a good point.  I think you're right that we should propose
language updates, even if we offer to apply the changes ourselves.

> The other day I saw an ad for a dress which said it was "ideal for lunch
> with the girls or after five drinks."

There's always BRIDESTOWN, (http://bridestown.com/) too.  I wonder where
the brides have been stown?

> 
>>>> +class _LazyObjectGetter(_ObjectGetter):
>>>> +    """Keep a record of a future object, and on request load it."""
>>
>> Should be "and, on request, load it."
> 
> I don't think it's incorrect as originally written, though yours might
> be clearer.  Sometimes I try to say "may be clearer as".

My understanding is that, when a sub-clause is inserted, it should have
a comma on either side.  Like that ;-)

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFLwMC0F+nu1YWqI0RArgrAJ9jECsiLjOJdZ9qKtutqVImf4weFwCeKWuJ
0nMU+wb4LJcHkyZ2HjASDWI=
=BCdF
-----END PGP SIGNATURE-----