[patch] make 'bzr ignore' take multiple arguments (bug 29488)

Cheuksan Edward Wang wang02139 at gmail.com
Wed Oct 11 00:47:21 BST 2006


OK. Here is the third try.

On 10/11/06, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Cheuksan Edward Wang wrote:
> > Thanks. I have modified it. Here is the new changeset.
>
> >              return
> > -        if name_pattern is None:
> > +        if name_pattern_list is None or name_pattern_list == []:
> >              raise BzrCommandError("ignore requires a NAME_PATTERN")
>
> ^^ perhaps this should be updated to say "ignore requires at least one
> NAME_PATTERN or --old-default-rules".
>
> > -        igns += name_pattern + '\n'
> > +     for name_pattern in name_pattern_list:
> > +         igns += name_pattern + '\n'
>
> ^^^ Please use spaces to indent, not tabs.
>
> Aaron
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
>
> iD8DBQFFK+ey0F+nu1YWqI0RAuIXAJ9pG6x6xluVHbzea0rFTox4Bqso4QCdErd+
> wSnDW3WcpziUDFHeL46lJEE=
> =pUb4
> -----END PGP SIGNATURE-----
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20061011/49b1cb41/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ignore_multiple_3.patch
Type: text/x-patch
Size: 9350 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061011/49b1cb41/attachment.bin 


More information about the bazaar mailing list