[PATCH] cascading lookup support in LocationConfig (bug 33430)

Aaron Bentley aaron.bentley at utoronto.ca
Sun Oct 8 23:59:19 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

James Henstridge wrote:
> On 19/09/06, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
>> >> If recurse=False were set for all automatic values, do you think
>> >> ignore_parents would still be useful?
>> >
>> > It depends on whether anyone was relying on the current shadowing
>> > behaviour or not.  Maybe it would be better to leave it out and see if
>> > anyone asks for the feature.
>>
>> Okay.  So I apologise for turning your patch into a design discussion.
>> Let's not let cascading block on config syntax discussion.  If you don't
>> mind producing a version that retains the existing recurse
>> functionality, I think I can approve that.  It's your choice whether to
>> include ignore_parents.
>>
>> We can deal with syntax enhancement separately.
> 
> Finally got around to cleaning up the previous patch, and have
> attached a new bundle.  The changes from the last version include:
> 
> 1. add back the recurse=Flase support.
> 2. removes the recurse optional argument for get_user_option()
> (doesn't make sense if policy gets set when setting the option).
> 
> It still has the ignore_parents support included.

+1 from me.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFKYLG0F+nu1YWqI0RAkvIAJ44At4+U67hPXFqTlr9t4ywPnHBbwCfdEuM
GNKudg6wpvTVkvizrn6L1Ig=
=ueln
-----END PGP SIGNATURE-----





More information about the bazaar mailing list