[MERGE] LockDir.lock_write() shouldn't require an email address

Richard Wilbur richard.wilbur at gmail.com
Tue Oct 3 15:39:50 BST 2006

On Fri, 2006-09-29 at 15:26 -0500, John Arbash Meinel wrote:
> The attached patch fixes a small bug in LockDir.
> Basically, it requires a semi-valid email address to be configured, or
> '.lock_write()' will fail.
> Also, extract_email_address() shouldn't be raising a generic BzrError.
> So this patch updates it to raise a better exception, and then has the
> callers catch the right exception.
> Because of inheritance, we don't need to do a deprecation phase, because
> NoEmailInUsername is a child of BzrError.
> John
> =:->

I searched the bazaar-vcs.org site for "deprecation phase" and it
returns with 0 pages/2344.  I searched for "deprecation" and it returned
five pages of which two mentioned bzr code.  BzrHistory under version
0.7 speaks of bzrlib.symbol_versioning being able to add is_deprecated
flag to methods, change their doc strings, and cause them to issue
DeprecationWarnings when called.

Is this related to the "deprecation phase" you mention above (albeit not
needed in this case)?  Where could I read a description of this practice
("deprecation phase")?


Richard Wilbur

More information about the bazaar mailing list