[bug][win32] selftest can't complete their work

[Robert Collins]

On Thu, 2006-09-28 at 10:02 -0500, John Arbash Meinel wrote:
> Lukáš Lalinský wrote:
> > Alexander Belchenko wrote:
> >>> Yeah, that's a lot of failures.  I suspect most of them are shallow,
> >>> but it's
> >>> hard to fix when I don't have a Windows development environment.  
> >> How I can help you to debug this?
> >> I don't have enough time to research your code from scratch, but I can
> >> try your patches or follow your suggestions.
> > 
> > Here is another patch. This should fix all remaining smart_transport selftest
> > problems on Windows. Most of them are bugs in the test code (e.g. 'file:///' is
> > not a valid local path URL on Windows), not the smart server itself.
> > 
> > -Lukáš
> > 
> 
> These seem to be valid changes to me. +1
> 
> Though I thought get_transport('/') would work if
> get_transport(local_path_to_url('/')) works.
> 
> Though I may understand if we are trying to get away from passing local
> paths to the get_transport() function.

+1 from me too, and I'm backporting it to 0.11 for the final release.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060929/d37e500b/attachment.pgp