[PING][MERGE] help topics

[John Arbash Meinel]

Goffredo Baroncelli wrote:
> On Friday 15 September 2006 23:58, Robert Collins wrote:
>> On Thu, 2006-09-14 at 13:46 -0500, John Arbash Meinel wrote:
>>> The attached patch was written by Goffredo and updated by myself. It
>>> adds help topics to the bzr help system. So you can type 'bzr help
>>> topics' to get a list of topics. And 'bzr help revisionspec' to get the
>>> currently registered revision specs.
>> This seems mostly reasonable. I have a few nits.
>>
>> Firstly the use of two dictionaries seems like its crying out for a
>> single dictionary with objects in it.
> I removed one dictionary.
> 
>> Secondly, the help strings for revspec are mostly non-pep8 - they are
>> missing the gap after the first line, which I think is a good discpline
>> for help readability as it ensures a meanginful summary has been
>> created.
> Done
> 
>> It needs a NEWS entry. And perhaps mention in the intro to bzr in the
>> tutorial or documentation.
> Done
> 
> Now do we can get a +1 ? :-)
> 
> Goffredo
> 

Did you send this to the mailing list, or just to me? I'd like to get
this merged right away now that 0.12 is open.

Also, do you have a patch, bundle, or branch of just your changes tacked
on to mine so that I can merge you rather than having to go around
again? Submitting a plain patch makes it difficult to sort out your new
changes from the earlier changes.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060925/aacfcd74/attachment.pgp