commit performance regression in 0.11

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> So I have a 2 comments:
> 
> 1) We almost have the infrastructure in place to remove a read_inventory
> call during commit. We just need to have the commit builder return the
> RevisionTree.

I don't see anything wrong with this, but it seems simpler to just call
set_parent_ids.  Yes, I realize that it will be a performance advantage
for dirstate, once it arrives, but right now it's a disadvantage.

> 2) Is there any way we can avoid the extra deserialize + serialize step
> for caching the basis inventory? Or do we just need to live with it
> until we make the new repository format the default?

The obvious solution would be for the repository serialization format to
determine the basis serialization format.  IIRC, Robert didn't like that
approach, because it exposed an implementation detail.

Another option would be for the basis serialization to work with both
formats, depending on what format is provided by the repository.

Finally, it would be possible to textually transform a format 5
inventory into a format 6 one.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFFGCyY0F+nu1YWqI0RAiWfAJ9q76Fe0OFn7YpUa6cpLWBU48RrmACeP+iW
tQ3iFBJZRa9FYWbEewQt22I=
=MDz5
-----END PGP SIGNATURE-----