[merge][0.11][critical] test log problems

John Arbash Meinel john at arbash-meinel.com
Sun Sep 24 18:28:23 BST 2006


Carl Friedrich Bolz wrote:
> Hi all!
> 
> John pointed out that there is a problem with the code that throws the
> log file away if a test is passing. The problem is that the log is
> _always_ thrown away, also for failing tests. This is due to a simple
> typo (see patch below) introduced by marienz when he tried to fix
> problem with doc test.
> 
> This makes the test suite pretty much unusable, since you never get the
> correct log output. Attached is a fix for the problem. I am working on a
> test for the problem, but I think this patch should go into the release
> and I am bit short on time. Sorry that I didn't write a test right away,
> that would have prevented the problem altogether.
> 
> Cheers,
> 
> Carl Friedrich
> 

I expanded on this with some test cases, since Carl didn't have time
right now.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fail-test-keep-log.patch
Type: text/x-patch
Size: 4196 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060924/aa863f4f/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060924/aa863f4f/attachment.pgp 


More information about the bazaar mailing list