[MERGE] don't accept unversioned files for commit (#50793)
Aaron Bentley
aaron.bentley at utoronto.ca
Fri Sep 22 20:58:17 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
John Arbash Meinel wrote:
> v-- I would fix the import lines to read:
>
> from bzrlib import (
> errors,
> tree,
> )
Okay.
> And then get rid of the import bzrlib.errors as errors. (And if there
> are other imports like this, do that as well.
> ^- This feels a little bit like we are doing some work, and then
> throwing it away.
Yes, that's exactly what we're doing.
> But I think it covers up our mistake, which is
> probably sufficient for now.
I had a look at switching commit over to using file ids, and it was far
too invasive a change for 0.11. Long term, I'd like to do that, though.
Because commit.py is doing argument validation, and that's really the
wrong place to do it.
> So you have my +1 for 0.11.
Thanks. Submitted with your changes.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFFFEBZ0F+nu1YWqI0RAgCvAJ9f22Nw53qWK8sj2ak/qlTufEiMqQCdGHUG
/B/sWHD0ArHs6U4kGsdEuCY=
=BfWn
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list