[merge][0.11] updates to rio and version_info

John Arbash Meinel john at arbash-meinel.com
Fri Sep 22 20:40:50 BST 2006


Aaron Bentley wrote:
> John Arbash Meinel wrote:

...

> 
>>> The Stanza api changes are not strictly necessary. I could instead
>>> always .encode() or .decode() before reading/adding a child Stanza. But
>>> doing it this way is better for performance, and I think more natural
>>> for people who want to use Stanzas.
> 
> My main beef here is treating bytestrings and unicode strings as
> interchangeable.  They're not usually, so that makes this a 'magic'
> interface.
> 
> Though I do wonder whether nested rio really makes sense.
> 
> Aaron

Attached is a bundle that layers on top of the others to provide
'read_stanza_unicode()' and use that preferentially when trying to read
data that is already in unicode form.

Does this make the fixes valid for 0.11? I'm also attaching the complete
diff, just in case you want to review it.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: read_stanza_unicode.patch
Type: text/x-patch
Size: 4251 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060922/1b014406/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rio-and-version-info-fixes.diff
Type: text/x-patch
Size: 13664 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060922/1b014406/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060922/1b014406/attachment.pgp 


More information about the bazaar mailing list