[PING] [PATCH] ignore log to stdout in benchmarks

[John Arbash Meinel]

Martin Pool wrote:
> On  7 Sep 2006, Carl Friedrich Bolz <cfbolz at gmx.de> wrote:
>> Carl Friedrich Bolz wrote:
>>> Carl Friedrich Bolz wrote:
>>>> Robert Collins wrote:
>>> [snip]
>>>>> I was suggesting the following:
>>>>> By default:
>>>>>  - successful or skipping tests delete the log from disk and throw away
>>>>> the contents
>>>>>  - failing or erroring tests put the log on disk until get_log_content()
>>>>> is called, when they read the file into memory and delete the log from
>>>>> disk.
>>>>>
>>>>> Tests that need to can request that the log on disk be explicitly kept.
>>>> I tried to implement that, see attached patch.
>>> Could somebody look at it again? see patch, the branch is also
>>> registered at launchpad as:
>>>
>>> http://launchpad.net/people/cfbolz/+branch/bzr/throw-test-log-away
>>>
>> Oops, here's the patch.
> 
> +1 from me.  Any other comments?
> 

+1 from me as well, and because it is only changing the tests, I think
it is still valid for inclusion in 0.11. I went ahead and submitted it.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060921/fb6c921b/attachment.pgp