Benchmark display plugin

Martin Pool mbp at canonical.com
Thu Sep 21 09:01:07 BST 2006


On  6 Sep 2006, Carl Friedrich Bolz <cfbolz at gmx.de> wrote:
> Hi all!
> 
> After some discussion with John, I decided to make the Benchmark display
> code a plugin, due to its rather heavy dependency on the PIL (if
> somebody still wants to have it in bzr.dev, we can discuss if of
> course). It lives at
> 
> http://codespeak.net/bzr/benchdisplay-plugin/

It looks like you tried to remove the external dependency on py.html,
but you missed one instance, so the plugin does not actually run :-(

=== modified file 'benchmark_report.py'
--- benchmark_report.py 2006-09-06 11:51:52 +0000
+++ benchmark_report.py 2006-09-21 07:52:13 +0000
@@ -369,7 +369,7 @@
         map_name = samples[0].test_id # link between the image and the
image map
         if max_value == 0:
             #nothing to draw
-            return (pyhtml.span('No value greater than 0'),
             py.html.span(''))
+            return (pyhtml.span('No value greater than 0'), pyhtml.span(''))

         step = 3 # pixels for each revision on x axis
         xsize = (len(revisions) - 1) * step +2

At a guess you used %s in vi :)

With that fixed it runs fine 

  http://benchmark.bazaar-vcs.org/benchmark_report.html

thanks
-- 
Martin




More information about the bazaar mailing list