[merge][0.11] bugfix 56815: export unicode files to tar+zip

[John Arbash Meinel]

John Arbash Meinel wrote:
> There are two patches attached. The first fixes 'bzr export' for both
> tar and zipfiles so that if the tree contains unicode filenames, they
> will be exported as utf-8 paths.
> 
> This fixes bug:
> https://launchpad.net/products/bzr/+bug/56815
> 
> We had done some discussion, and it is possible that you would want to
> use a different path depending on the platform. But utf-8 is probably
> the most consistent thing. And it only might fail on windows. But since
> right now we fail on all platforms, it is still better to do this.
> 
> The second patch just cleans up the export tests to conform to our
> preferred style (use self.make_branch_and_tree, rather than runbzr, etc).
> 
> This may be too much of a change to slip into 0.11, but I think it is small.
> 
> John
> =:->

One more follow-up bundle. After running the tests on Windows to make
sure they all passed, I found that some of the tests were leaving the
tarballs open, and I found that there were still a lot of export tests
in blackbox/test_too_much.py

So I pulled out a lot of them into the blackbox/test_export.py. And then
refactored them to follow our current testing practices.

The only export stuff left in blackbox/test_too_much.py is the
OldTests.test_bzr() which is sort of a giant test-everything (as of
bzr-0.0.1 or so). And it would be difficult to make that a lot cleaner.
Hopefully the other tests will cover it just as well.

Also, there was a doc-test for 'bzrlib.export.get_root_name()' but
bzrlib.export was not in the list of files to be doctested. So this
patch adds it back in.

No functional changes here, just test cleanups.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup-export-tests.patch
Type: text/x-patch
Size: 8703 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060920/6417a818/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060920/6417a818/attachment.pgp